fix(e2ei): set user display name correctly for the certificate downloaded file (WPB-8606) #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yamil Medina <[email protected]>
Co-authored-by: AndroidBob <[email protected]>
Co-authored-by: yamilmedina <[email protected]>
…-6145) - cherrypick (#2635)
…2642) Co-authored-by: Yamil Medina <[email protected]>
Co-authored-by: Yamil Medina <[email protected]>
…rsation (WPB-5834) (#2659)
Co-authored-by: Oussama Hassine <[email protected]>
…rash [WPB-4716] (#2661)
Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
…ce only dependencies or not (#2890)
Co-authored-by: Mojtaba Chenani <[email protected]>
mchenani
requested review from
yamilmedina,
alexandreferris,
borichellow and
Garzas
Test Results820 tests 820 ✅ 7m 55s ⏱️ Results for commit 3b61110. ♻️ This comment has been updated with latest results. |
|
Build 4477 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4478 succeeded. The build produced the following APK's: |
MohamadJaara
requested changes
Apr 26, 2024
Comment on lines
+21
to
+23
| val certificateString: String, | ||
| val isSelfUser: Boolean, | ||
| val otherUserName: String? = null |
There was a problem hiding this comment.
- we should keep using the handle instead of the name, since the handle is unique.
- to simplify the screen, we can only pass the user ID and fetch the handle from DB when needed.
There was a problem hiding this comment.
this feature is fancy and no requirements on it, and display name on the file might be more readable, didn't want to do a query to fetch data that is unnecessary, also since we add a date to the end of the file, duplicate names won't occur.
MohamadJaara
force-pushed
the
release/candidate
branch
from
5638df4
to
70f61a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aded file
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Set display name for the certificate downloaded file.
Issues
The self user name was set even for other users cert.
Causes (Optional)
Wasn't handled.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.